fix: Clip ripple effect for default Button style in materialDesign:PopupBox#3983
Merged
Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom Dec 19, 2025
Merged
fix: Clip ripple effect for default Button style in materialDesign:PopupBox#3983Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
materialDesign:PopupBox#3983Keboo merged 2 commits intoMaterialDesignInXAML:masterfrom
Conversation
…opupBox` Use the BorderClipConverter to clip the ripple to the bounds of the button
Keboo
reviewed
Dec 13, 2025
src/MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.PopupBox.xaml
Outdated
Show resolved
Hide resolved
Set ClipToBounds="True" instead of using the `BorderClipConverter` in the Button ControlTemplate to prevent child elements from rendering outside the template boundaries.
Keboo
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3982
Use the
BorderClipConverterto clip the ripple to the Buttons (MaterialDesignPopupBoxButton) bounds.The current behavior can be seen in the linked issue.
New behavior:
popupRipplePost.mp4